mirror of
https://github.com/linux-can/can-utils.git
synced 2026-09-22 16:09:52 +02:00
Marc Kleine-Budde
aa902ae2af
The `file_path` of `strchr(file_path, '/')` is a `const char *`. In this
case the `strchr()` in debian experimental returns a `const char *`,
leading to this error message:
```
mcp251xfd/mcp251xfd-regmap.c:75:13: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
75 | tmp = strchr(file_path, '/');
| ^
```
Fix the error by using the return value from `strchr()` directly in the
`if()`.
Link: https://github.com/linux-can/can-utils/actions/runs/22649777324/job/65679726209?pr=619
98 lines
1.8 KiB
C
98 lines
1.8 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
//
|
|
// Microchip MCP251xFD Family CAN controller debug tool
|
|
//
|
|
// Copyright (c) 2020, 2022, 2023 Pengutronix,
|
|
// Marc Kleine-Budde <kernel@pengutronix.de>
|
|
//
|
|
|
|
#include <errno.h>
|
|
#include <fcntl.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
#include <sys/stat.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include "mcp251xfd.h"
|
|
#include "mcp251xfd-dump-userspace.h"
|
|
|
|
static int
|
|
do_mcp251xfd_regmap_read(struct mcp251xfd_priv *priv,
|
|
struct mcp251xfd_mem *mem,
|
|
const char *file_path)
|
|
{
|
|
FILE *reg_file;
|
|
uint16_t reg;
|
|
uint32_t val;
|
|
unsigned int n = 0;
|
|
int ret, err = 0;
|
|
|
|
reg_file = fopen(file_path, "r");
|
|
if (!reg_file)
|
|
return -errno;
|
|
|
|
while ((ret = fscanf(reg_file, "%hx: %x\n", ®, &val)) != EOF) {
|
|
if (ret != 2) {
|
|
ret = fscanf(reg_file, "%*[^\n]\n");
|
|
|
|
continue;
|
|
}
|
|
|
|
if (reg >= ARRAY_SIZE(mem->buf)) {
|
|
err = -EINVAL;
|
|
goto out_close;
|
|
}
|
|
|
|
*(uint32_t *)(mem->buf + reg) = val;
|
|
|
|
n++;
|
|
}
|
|
|
|
printf("regmap: Found %u registers in %s\n", n, file_path);
|
|
if (!n)
|
|
err = -EINVAL;
|
|
|
|
out_close:
|
|
fclose(reg_file);
|
|
|
|
return err;
|
|
}
|
|
|
|
int mcp251xfd_regmap_read(struct mcp251xfd_priv *priv,
|
|
struct mcp251xfd_mem *mem,
|
|
const char *file_path)
|
|
{
|
|
char *tmp;
|
|
int err;
|
|
|
|
err = do_mcp251xfd_regmap_read(priv, mem, file_path);
|
|
if (!err)
|
|
return 0;
|
|
|
|
/* maybe it's something like "spi0.0" */
|
|
if (strchr(file_path, '/'))
|
|
return -ENOENT;
|
|
|
|
/* first try literally */
|
|
err = asprintf(&tmp, "/sys/kernel/debug/regmap/%s/registers", file_path);
|
|
if (err == -1)
|
|
return -errno;
|
|
|
|
err = do_mcp251xfd_regmap_read(priv, mem, tmp);
|
|
free (tmp);
|
|
if (!err)
|
|
return 0;
|
|
|
|
/* then add "-crc" */
|
|
err = asprintf(&tmp, "/sys/kernel/debug/regmap/%s-crc/registers", file_path);
|
|
if (err == -1)
|
|
return -errno;
|
|
|
|
err = do_mcp251xfd_regmap_read(priv, mem, tmp);
|
|
free (tmp);
|
|
|
|
return err;
|
|
}
|