canaddr2str() from testj1939 and libj1939's libj1939_addr2str provide
the same functionality. Remove the local helper function and use
libj1939_addr2str instead.
Signed-off-by: Bastian Stender <bst@pengutronix.de>
The can-j1939 kernel part only follows & validates inbound & outbound
address claim packets. Jacd implements the part that chooses an address
and emits the address claim packet.
Signed-off-by: Kurt Van Dijck <kurt.van.dijck@eia.be>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
jsr sends data on <stdin> to j1939, and received j1939 data
is put on <stdout>.
Signed-off-by: Kurt Van Dijck <kurt.van.dijck@eia.be>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
libj1939 provides a parser for struct sockaddr_can with j1939 info
Signed-off-by: Kurt Van Dijck <kurt.van.dijck@eia.be>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
This configuration performs build tests for GCC and Clang
compilers.
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Hardware timestamps have been introduced in Linux 2.6.30. Check for the
availability of SO_TIMESTAMPING and print an appropriate error message if
missing. Additionally fix some style issues and define the proper length
of ctrlmsg[].
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
GitHub user 'crossband' raised an issue regarding the strict-aliasing compiler
warning in his specific setup: https://github.com/linux-can/can-utils/issues/42
In fact memcpy() and memset() are a better solution than the former pointer
magics, so remove the issues and the compiler warning flag too.
Reported-by: crossband (https://github.com/crossband)
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Alan sent a pull request to update the README.md with some markdown tweaks
and a SocketCAN logo. Good idea!
After creating a SocketCAN logo PNG in the can-logos repository we can
reference the PNG inside the linux-can organization.
A license file needs to be added too - but this has to be discussed on the
mailing list first.
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
System startup needs to wait for tun device to be created before
continuing on use of the tun device. Add -D option to fork a daemon of
isotptun and exit(EXIT_SUCCESS) when the tun device can be used.
Log errors to syslog when daemonized or to stderr when in foreground.
Signed-off-by: Marko Kohtala <marko.kohtala@gmail.com>
Command line parsing error messages are printed to stdout. Other errors
and usage goes to stderr.
Change to print errors to stderr.
Signed-off-by: Marko Kohtala <marko.kohtala@gmail.com>
Exit code does not tell if the service was provided or if it was not
provided due to command line or setup errors.
Change errors to return EXIT_FAILURE instead of 0. Also change other uses
of 0 to EXIT_SUCCESS and 1 to EXIT_FAILURE for clarity and POSIX
conformance.
Signed-off-by: Marko Kohtala <marko.kohtala@gmail.com>
The sscanf() function to parse bcmserver command strings limited the length of
the CAN netdevice name to six characters. With this patch the length is derived
from the IFNAMSIZ which defines the space in ifr.ifr_name.
Signed-off-by: Jiho Chu <jiho.chu@samsung.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
With glibc versions before 2.17, we get following build error:
canfdtest.o: In function `millisleep':
canfdtest.c:(.text+0x212): undefined reference to `clock_nanosleep'
collect2: error: ld returned 1 exit status
make[1]: *** [canfdtest] Error 1
make[1]: *** Waiting for unfinished jobs....
glibc versions before 2.17 needs to link with -lrt for
clock_nanosleep(). This patch adds support to detect if linking with
librt is required.
This build issue is detected by Buildroot autobuilder:
http://autobuild.buildroot.net/results/0e5/0e5242376ff6aa82e89ed1172350e05009d48156/build-end.log
Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
This patch fixes this bug
https://github.com/linux-can/can-utils/issues/13
Modified the existing millisleep function to use clock_nanosleep with
MONOTONIC clock and relative timeout.
Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
Bastian Stender
Marc Kleine-Budde
Marc Kleine-Budde
Kurt Van Dijck
Yegor Yefremov
Oliver Hartkopp
Søren Holm
Fabián Inostroza
jschall
Heydar Elahi
Marko Kohtala
Jiho Chu
Rahul Bedarkar
Ramesh Shanmugasundaram