sven/can-utils
1
0
Fork 0
mirror of https://github.com/linux-can/can-utils.git synced 2026-08-05 22:40:03 +02:00
Code Issues Packages Projects Releases Wiki Activity
696 Commits 1 Branch 9 Tags
4573e852f97dec6c18748d1c0aeebd4213173af4
Commit Graph
6 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Bastian StenderandOleksij Rempel 54ff81cc40 testj1939: add omit bind option 
This option is needed for j1939 socket functionality test.
Connects wihout bind should not work.

Signed-off-by: Bastian Stender <bst@pengutronix.de>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
 2018-09-21 11:31:22 +02:00
Bastian StenderandOleksij Rempel 1ba9b86451 testj1939: add re-bind support 
This option is needed for j1939 socket functionality test.
Binding to a socket and rebinding to the socket with e.g. a different SA
should work.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Bastian Stender <bst@pengutronix.de>
 2018-09-21 11:31:04 +02:00
Bastian Stender cf039f14fb jacd: provide interface index while opening socket and address claiming 
This is a direct consequence of not allowing bind to any device
("3cb6a1204598 j1939: socket: bind() cleanups"), i.e. can_ifindex == 0.
This means before this change jacd would receive from any interface that
was opened by another program.

Without this patch jacd fails with:

  acd: bind(): No such device

A more verbose call shows the missing interface:

$ jacd -v 1122334455667788
jacd: ready for can0:1122334455667788
- socket(PF_CAN, SOCK_DGRAM, CAN_J1939);
- setsockopt(, SOL_SOCKET, SO_BINDTODEVICE, can0, 4);
- setsockopt(, SOL_CAN_J1939, SO_J1939_FILTER, <filter>, 84);
- setsockopt(, SOL_CAN_J1939, SO_J1939_RECV_OWN, 1, 4);
- bind(, :fe,0ee00,1122334455667788, 24);
jacd: bind(): No such device

Signed-off-by: Bastian Stender <bst@pengutronix.de>
 2018-01-22 14:12:44 +01:00
Bastian Stender 6133ac94f0 jacd: print relevant API calls on verbose 
The output is now comparable to testj1939's -v output.

Signed-off-by: Bastian Stender <bst@pengutronix.de>
 2018-01-22 14:12:44 +01:00
Bastian Stender 1f3f2f6163 testj1939: use address to string function from libj1939 
canaddr2str() from testj1939 and libj1939's libj1939_addr2str provide
the same functionality. Remove the local helper function and use
libj1939_addr2str instead.

Signed-off-by: Bastian Stender <bst@pengutronix.de>
 2018-01-22 12:27:15 +01:00
Bastian StenderandMarc Kleine-Budde 680d5c30c3 testj1939: initialize verbose variable 
Signed-off-by: Bastian Stender <bst@pengutronix.de>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
 2018-01-18 14:53:43 +01:00