sven/libicsneo
1
0
Fork 0
mirror of https://github.com/intrepidcs/libicsneo.git synced 2026-11-04 12:59:07 +01:00
Code Issues Projects Releases Wiki Activity

EventManager: Fix potential ABBA deadlock if callback contains locks

Browse Source
This commit is contained in:
Max Brombach
2026-10-02 15:38:59 -04:00
committed by Kyle Schwarz
parent 3932b54947
commit fb241dc5cd
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
api/icsneocpp/eventmanager.cpp
+7 -3
View File
@@ -99,9 +99,13 @@ void EventManager::addEventInternal(APIEvent event) {
} }
void EventManager::runCallbacks(APIEvent event) { void EventManager::runCallbacks(APIEvent event) {
std::lock_guard<std::mutex> lk(callbacksMutex); std::map<int, icsneo::EventCallback> tempCallbacks;
for(auto& i : callbacks) {
i.second.callIfMatch(std::make_shared<APIEvent>(event)); std::lock_guard<std::mutex> lk(callbacksMutex);
tempCallbacks = callbacks;
}
for(auto& i : tempCallbacks)
i.second.callIfMatch(std::make_shared<APIEvent>(event));
} }
void EventManager::setEventLimit(size_t newLimit) { void EventManager::setEventLimit(size_t newLimit) {