sven/libicsneo
1
0
Fork 0
mirror of https://github.com/intrepidcs/libicsneo.git synced 2026-08-05 17:38:35 +02:00
Code Issues Projects Releases Wiki Activity

Settings: Fix an issue where read errors were not properly reported

Browse Source 
Since we were not failing the open for a settings read failure,
any errors would go unnoticed.
This commit is contained in:
Paul Hollinsky
2021-04-11 22:37:44 -04:00
parent e82b5d15e0
commit d79f735df8
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
device/device.cpp
+10 -1
View File
@@ -202,8 +202,17 @@ bool Device::open() {
return false; return false;
} }
if(!settings->disabled) if(!settings->disabled) {
// Since we will not fail the open if a settings read fails,
// downgrade any errors to warnings. Otherwise the error will
// go unnoticed in the opening thread's getLastError buffer.
const bool downgrading = EventManager::GetInstance().isDowngradingErrorsOnCurrentThread();
if(!downgrading)
EventManager::GetInstance().downgradeErrorsOnCurrentThread();
settings->refresh(); settings->refresh();
if(!downgrading)
EventManager::GetInstance().cancelErrorDowngradingOnCurrentThread();
}
MessageFilter filter; MessageFilter filter;
filter.includeInternalInAny = true; filter.includeInternalInAny = true;