sven/libicsneo
1
0
Fork 0
mirror of https://github.com/intrepidcs/libicsneo.git synced 2026-08-05 09:28:40 +02:00
Code Issues Projects Releases Wiki Activity

CANPacket: Fix invalid length check

Browse Source 
This case is already checked above, and further
was invalid since the length had already been
translated to the numeric (0-64) value.
This commit is contained in:
Paul Hollinsky
2021-06-10 15:03:34 -04:00
parent 21e93d1f73
commit d4f6c12394
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
communication/packet/canpacket.cpp
+1 -1
View File
@@ -109,7 +109,7 @@ bool HardwareCANPacket::EncodeFromMessage(const CANMessage& message, std::vector
const optional<uint8_t> lenFromDLC = CANFD_DLCToLength(message.dlcOnWire); const optional<uint8_t> lenFromDLC = CANFD_DLCToLength(message.dlcOnWire);
if (lenFromDLC.has_value() && *lenFromDLC != 0) { if (lenFromDLC.has_value() && *lenFromDLC != 0) {
if (*lenFromDLC < lengthNibble || *lenFromDLC > 0xF) { if (*lenFromDLC < lengthNibble) {
report(APIEvent::Type::MessageMaxLengthExceeded, APIEvent::Severity::Error); report(APIEvent::Type::MessageMaxLengthExceeded, APIEvent::Severity::Error);
return false; return false;
} }