Device: Conditionally retrieve component versions

device/device.cpp

@@ -220,10 +220,13 @@ bool Device::open(OpenFlags flags, OpenStatusHandler handler) {
 
 	// Get component versions *after* the extension "onDeviceOpen" hooks (e.g. device reflashes)
 	
-	if (auto compVersions = com->getComponentVersionsSync())
+	if(supportsComponentVersions()) {
-		componentVersions = std::move(*compVersions);
+		if(auto compVersions = com->getComponentVersionsSync())
-	else
+			componentVersions = std::move(*compVersions);
-		report(APIEvent::Type::NoDeviceResponse, APIEvent::Severity::EventWarning);
+		else
+			// It's possible the device is on older firmware so don't return false here
+			report(APIEvent::Type::NoDeviceResponse, APIEvent::Severity::EventWarning);
+	}
 
 	if(!settings->disabled) {
 		// Since we will not fail the open if a settings read fails,

include/icsneo/device/device.h

@@ -715,6 +715,8 @@ public:
 
 	virtual bool isOnlineSupported() const { return true; }
 
+	virtual bool supportsComponentVersions() const { return false; }
+
 protected:
 	bool online = false;
 	int messagePollingCallbackID = 0;

include/icsneo/device/tree/etherbadge/etherbadge.h

@@ -26,6 +26,8 @@ public:
 		return supportedNetworks;
 	}
 
+	bool supportsComponentVersions() const override { return true; }
+
 protected:
 	EtherBADGE(neodevice_t neodevice, const driver_factory_t& makeDriver) : Device(neodevice) {
 		initialize<EtherBADGESettings>(makeDriver);

include/icsneo/device/tree/neovifire2/neovifire2.h

@@ -87,6 +87,8 @@ public:
 		};
 	}
 
+	bool supportsComponentVersions() const override { return true; }
+
 protected:
 	NeoVIFIRE2(neodevice_t neodevice, const driver_factory_t& makeDriver) : Device(neodevice) {
 		initialize<NeoVIFIRE2Settings, Disk::NeoMemoryDiskDriver, Disk::NeoMemoryDiskDriver>(makeDriver);
@@ -99,7 +101,7 @@ protected:
 		}
 	}
 
-	bool currentDriverSupportsDFU() const override { return com->driver->isEthernet(); }
+	bool currentDriverSupportsDFU() const override { return !com->driver->isEthernet(); }
 
 	void setupPacketizer(Packetizer& packetizer) override {
 		Device::setupPacketizer(packetizer);

include/icsneo/device/tree/neovifire3/neovifire3.h

@@ -50,6 +50,8 @@ public:
 		return supportedNetworks;
 	}
 
+	bool supportsComponentVersions() const override { return true; }
+
 protected:
 	NeoVIFIRE3(neodevice_t neodevice, const driver_factory_t& makeDriver) : Device(neodevice) {
 		initialize<NeoVIFIRE3Settings, Disk::ExtExtractorDiskReadDriver, Disk::NeoMemoryDiskDriver>(makeDriver);

include/icsneo/device/tree/neovifire3flexray/neovifire3flexray.h

@@ -52,6 +52,8 @@ public:
 		return supportedNetworks;
 	}
 
+	bool supportsComponentVersions() const override { return true; }
+
 protected:
 	NeoVIFIRE3FlexRay(neodevice_t neodevice, const driver_factory_t& makeDriver) : Device(neodevice) {
 		initialize<NeoVIFIRE3FlexRaySettings, Disk::ExtExtractorDiskReadDriver, Disk::NeoMemoryDiskDriver>(makeDriver);

include/icsneo/device/tree/neovired2/neovired2.h

@@ -35,6 +35,8 @@ public:
 		return supportedNetworks;
 	}
 
+	bool supportsComponentVersions() const override { return true; }
+
 protected:
 	NeoVIRED2(neodevice_t neodevice, const driver_factory_t& makeDriver) : Device(neodevice) {
 		initialize<NeoVIRED2Settings, Disk::ExtExtractorDiskReadDriver, Disk::NeoMemoryDiskDriver>(makeDriver);

include/icsneo/device/tree/plasion/neoviion.h

@@ -15,6 +15,8 @@ public:
 	// USB PID is 0x0901, standard driver is FTDI
 	ICSNEO_FINDABLE_DEVICE_BY_PID(NeoVIION, DeviceType::ION, 0x0901);
 
+	bool supportsComponentVersions() const override { return true; }
+
 private:
 	NeoVIION(neodevice_t neodevice, const driver_factory_t& makeDriver) : Plasion(neodevice) {
 		initialize<NullSettings, Disk::PlasionDiskReadDriver, Disk::NeoMemoryDiskDriver>(makeDriver);

include/icsneo/device/tree/radepsilon/radepsilon.h

@@ -24,6 +24,8 @@ public:
 		return supportedNetworks;
 	}
 
+	bool supportsComponentVersions() const override { return true; }
+
 protected:
 	RADEpsilon(neodevice_t neodevice, const driver_factory_t& makeDriver) : Device(neodevice) {
 		initialize(makeDriver);

include/icsneo/device/tree/radjupiter/radjupiter.h

@@ -29,6 +29,8 @@ public:
 
 	bool getEthPhyRegControlSupported() const override { return true; }
 
+	bool supportsComponentVersions() const override { return true; }
+
 protected:
 	RADJupiter(neodevice_t neodevice, const driver_factory_t& makeDriver) : Device(neodevice) {
 		initialize<RADJupiterSettings>(makeDriver);

include/icsneo/device/tree/radmoon2/radmoon2zl.h

@@ -16,6 +16,8 @@ public:
 
 	uint8_t getPhyAddrOrPort() const override { return 1; }
 
+	bool supportsComponentVersions() const override { return true; }
+
 protected:
 	RADMoon2ZL(neodevice_t neodevice, const driver_factory_t& makeDriver) : RADMoon2Base(neodevice) {
 		initialize<RADMoon2Settings>(makeDriver);

include/icsneo/device/tree/radmoon3/radmoon3.h

@@ -27,6 +27,8 @@ public:
 
 	bool isOnlineSupported() const override { return false; }
 
+	bool supportsComponentVersions() const override { return true; }
+
 protected:
 	RADMoon3(neodevice_t neodevice, const driver_factory_t& makeDriver) : Device(neodevice) {
 		initialize<RADMoon3Settings>(makeDriver);

include/icsneo/device/tree/radmoonduo/radmoonduo.h

@@ -25,6 +25,8 @@ public:
 
 	bool getEthPhyRegControlSupported() const override { return true; }
 
+	bool supportsComponentVersions() const override { return true; }
+
 protected:
 	RADMoonDuo(neodevice_t neodevice, const driver_factory_t& makeDriver) : Device(neodevice) {
 		initialize<RADMoonDuoSettings>(makeDriver);

include/icsneo/device/tree/radpluto/radpluto.h

@@ -34,6 +34,8 @@ public:
 
 	bool getEthPhyRegControlSupported() const override { return true; }
 
+	bool supportsComponentVersions() const override { return true; }
+
 protected:
 	RADPluto(neodevice_t neodevice, const driver_factory_t& makeDriver) : Device(neodevice) {
 		initialize<RADPlutoSettings>(makeDriver);

include/icsneo/device/tree/valuecan3/valuecan3.h

@@ -22,6 +22,8 @@ public:
 		return supportedNetworks;
 	}
 
+	bool supportsComponentVersions() const override { return true; }
+
 private:
 	ValueCAN3(neodevice_t neodevice, const driver_factory_t& makeDriver) : Device(neodevice) {
 		initialize<ValueCAN3Settings>(makeDriver);

include/icsneo/device/tree/valuecan4/valuecan4.h

@@ -12,6 +12,8 @@ class ValueCAN4 : public Device {
 public:
 	// All ValueCAN 4 devices share a USB PID of 0x1101
 
+	bool supportsComponentVersions() const override { return true; }
+
 protected:
 	using Device::Device;
 

include/icsneo/device/tree/vividcan/vividcan.h

@@ -29,6 +29,8 @@ public:
 
 	bool isOnlineSupported() const override { return false; }
 
+	bool supportsComponentVersions() const override { return true; }
+
 protected:
 	VividCAN(neodevice_t neodevice, const driver_factory_t& makeDriver) : Device(neodevice) {
 		initialize<VividCANSettings>(makeDriver);