sven
/
libicsneo
mirror of https://github.com/intrepidcs/libicsneo.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Reworked updating LEDState to use sendCommand() instead of transmit()

checksum-failure-logging
EricLiu2000 2019-06-14 16:09:19 -04:00
parent 28fc98c475
commit a4a42c8704
3 changed files with 22 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
communication/encoder.cpp
View File

@ -103,9 +103,23 @@ bool Encoder::encode(std::vector<uint8_t>& result, const std::shared_ptr<Message
bool Encoder::encode(std::vector<uint8_t>& result, Command cmd, std::vector<uint8_t> arguments) { bool Encoder::encode(std::vector<uint8_t>& result, Command cmd, std::vector<uint8_t> arguments) {
auto msg = std::make_shared<Message>(); auto msg = std::make_shared<Message>();
msg->network = Network::NetID::Main51; if(cmd == Command::UpdateLEDState) {
msg->data.reserve(arguments.size() + 1); /* NetID::Device is a super old command type.
msg->data.push_back((uint8_t)cmd); * It has a leading 0x00 byte, a byte for command, and a byte for an argument.
msg->data.insert(msg->data.end(), std::make_move_iterator(arguments.begin()), std::make_move_iterator(arguments.end())); * In this case, command 0x06 is SetLEDState.
* This old command type is not really used anywhere else.
*/
msg->network = Network::NetID::Device;
msg->data.reserve(3);
msg->data.push_back(0x00);
msg->data.push_back(0x06);
msg->data.push_back(arguments.at(0));
} else {
msg->network = Network::NetID::Main51;
msg->data.reserve(arguments.size() + 1);
msg->data.push_back((uint8_t)cmd);
msg->data.insert(msg->data.end(), std::make_move_iterator(arguments.begin()), std::make_move_iterator(arguments.end()));
}
return encode(result, msg); return encode(result, msg);
} }

11
device/device.cpp
View File

@ -300,13 +300,6 @@ void Device::handleInternalMessage(std::shared_ptr<Message> message) {
} }
void Device::updateLEDState() { void Device::updateLEDState() {
/* NetID::Device is a super old command type. std::vector<uint8_t> args {(uint8_t) ledState};
* It has a leading 0x00 byte, a byte for command, and a byte for an argument. com->sendCommand(Command::UpdateLEDState, args);
* In this case, command 0x06 is SetLEDState.
* This old command type is not really used anywhere else.
*/
auto msg = std::make_shared<Message>();
msg->network = Network::NetID::Device;
msg->data = {0x00, 0x06, uint8_t(ledState)};
transmit(msg);
} }

3
include/icsneo/communication/command.h
View File

@ -10,7 +10,8 @@ enum class Command : uint8_t {
//GetSettings = 0xA5, // Previously known as RED_CMD_READ_BAUD_REQ, now unused //GetSettings = 0xA5, // Previously known as RED_CMD_READ_BAUD_REQ, now unused
SaveSettings = 0xA6, SaveSettings = 0xA6,
SetDefaultSettings = 0xA8, // Follow up with SaveSettings to write to EEPROM SetDefaultSettings = 0xA8, // Follow up with SaveSettings to write to EEPROM
ReadSettings = 0xC7 // Previously known as 3G_READ_SETTINGS_EX ReadSettings = 0xC7, // Previously known as 3G_READ_SETTINGS_EX
UpdateLEDState = 0xA7
}; };
} }