sven
/
libicsneo
mirror of https://github.com/intrepidcs/libicsneo.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Encoder: Add 1 to host-to-device long format packets 

Vehicle Spy 3 does this, it's a long-standing firmware idiosyncrasy.

Due to the way the device handles packets, this didn't cause a loss of
communication, only a "host to device byte" app error under certain
circumstances.
pull/43/head
Paul Hollinsky 2021-11-16 19:35:20 -05:00
parent 181223375a
commit 9d5bad94d4
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
communication/encoder.cpp
View File

@ -109,9 +109,10 @@ bool Encoder::encode(const Packetizer& packetizer, std::vector<uint8_t>& result,
if(shortFormat) { if(shortFormat) {
buffer.insert(buffer.begin(), (uint8_t(buffer.size()) << 4) | uint8_t(message->network.getNetID())); buffer.insert(buffer.begin(), (uint8_t(buffer.size()) << 4) | uint8_t(message->network.getNetID()));
} else { } else {
// Size in long format is the size of the entire packet // Size for the host-to-device long format is the size of the entire packet + 1
// So +1 for AA header, +1 for short format header, +2 for long format size, and +2 for long format NetID // So +1 for AA header, +1 for short format header, +2 for long format size, and +2 for long format NetID
uint16_t size = uint16_t(buffer.size()) + 1 + 1 + 2 + 2; // Then an extra +1, due to a firmware idiosyncrasy
uint16_t size = uint16_t(buffer.size()) + 1 + 1 + 2 + 2 + 1;
buffer.insert(buffer.begin(), { buffer.insert(buffer.begin(), {
(uint8_t)Network::NetID::RED, // 0x0C for long message (uint8_t)Network::NetID::RED, // 0x0C for long message
(uint8_t)size, // Size, little endian 16-bit (uint8_t)size, // Size, little endian 16-bit