From 87c10410e82e0551bdb8f24b2c7cc5ad145aa617 Mon Sep 17 00:00:00 2001 From: Kyle Schwarz Date: Tue, 12 May 2026 15:58:11 -0400 Subject: [PATCH] Servd: Remove no devices found event --- api/icsneocpp/event.cpp | 3 --- bindings/python/icsneopy/api/event.cpp | 1 - include/icsneo/api/event.h | 1 - platform/servd.cpp | 4 ---- 4 files changed, 9 deletions(-) diff --git a/api/icsneocpp/event.cpp b/api/icsneocpp/event.cpp index dc7604ea..6b641d1c 100644 --- a/api/icsneocpp/event.cpp +++ b/api/icsneocpp/event.cpp @@ -167,7 +167,6 @@ static constexpr const char* SERVD_POLL_ERROR = "Error polling on Servd socket"; static constexpr const char* SERVD_NODATA_ERROR = "No data received from Servd"; static constexpr const char* SERVD_JOIN_MULTICAST_ERROR = "Error joining Servd multicast group"; static constexpr const char* SERVD_NOT_REACHABLE = "Could not reach Servd; ensure it is installed and running"; -static constexpr const char* SERVD_NO_DEVICES_FOUND = "Servd is running but no devices found"; // DXX static constexpr const char* DXX_ERROR_SYS = "System error, check errno/GetLastError()"; @@ -442,8 +441,6 @@ const char* APIEvent::DescriptionForType(Type type) { return SERVD_JOIN_MULTICAST_ERROR; case Type::ServdNotReachable: return SERVD_NOT_REACHABLE; - case Type::ServdNoDevicesFound: - return SERVD_NO_DEVICES_FOUND; // DXX case Type::DXXErrorSys: diff --git a/bindings/python/icsneopy/api/event.cpp b/bindings/python/icsneopy/api/event.cpp index 919e1a2c..165b732f 100644 --- a/bindings/python/icsneopy/api/event.cpp +++ b/bindings/python/icsneopy/api/event.cpp @@ -127,7 +127,6 @@ void init_event(pybind11::module_& m) { .value("ServdNoDataError", APIEvent::Type::ServdNoDataError) .value("ServdJoinMulticastError", APIEvent::Type::ServdJoinMulticastError) .value("ServdNotReachable", APIEvent::Type::ServdNotReachable) - .value("ServdNoDevicesFound", APIEvent::Type::ServdNoDevicesFound) .value("DXXErrorSys", APIEvent::Type::DXXErrorSys) .value("DXXErrorInt", APIEvent::Type::DXXErrorInt) .value("DXXErrorOverflow", APIEvent::Type::DXXErrorOverflow) diff --git a/include/icsneo/api/event.h b/include/icsneo/api/event.h index 9db3cd12..ac14a628 100644 --- a/include/icsneo/api/event.h +++ b/include/icsneo/api/event.h @@ -166,7 +166,6 @@ public: ServdNoDataError = ServdBindError + 9, ServdJoinMulticastError = ServdBindError + 10, ServdNotReachable = ServdBindError + 11, - ServdNoDevicesFound = ServdBindError + 12, // DXX DXXErrorSys = 0x6100, diff --git a/platform/servd.cpp b/platform/servd.cpp index ec2f6169..1910114f 100644 --- a/platform/servd.cpp +++ b/platform/servd.cpp @@ -67,7 +67,6 @@ void Servd::Find(std::vector& found) { EventManager::GetInstance().add(APIEvent::Type::ServdTransceiveError, APIEvent::Severity::Error); return; } - const size_t preCount = found.size(); bool parseError = false; const auto lines = split(response, '\n'); for(auto&& line : lines) { @@ -96,9 +95,6 @@ void Servd::Find(std::vector& found) { return std::make_unique(err, forDevice, address); }; } - if(!parseError && found.size() == preCount) { - EventManager::GetInstance().add(APIEvent::Type::ServdNoDevicesFound, APIEvent::Severity::EventInfo); - } } Servd::Servd(const device_eventhandler_t& err, neodevice_t& forDevice, const Address& address) :