Reordered error downgrading, order of going offline, and renamed locks

communication/communication.cpp

@@ -156,14 +156,15 @@ void Communication::readTask() {
 
 					std::lock_guard<std::mutex> lk(messageCallbacksLock);
 
-					// We want callbacks to be able to access errors
-					EventManager::GetInstance().cancelErrorDowngradingOnCurrentThread();
 					for(auto& cb : messageCallbacks) {
 						if(!closing) { // We might have closed while reading or processing
+							// We want callbacks to be able to access errors
+							EventManager::GetInstance().cancelErrorDowngradingOnCurrentThread();
 							cb.second.callIfMatch(msg);
+							EventManager::GetInstance().downgradeErrorsOnCurrentThread();
 						}
 					}
-					EventManager::GetInstance().downgradeErrorsOnCurrentThread();
+					
 				}
 			}
 		}

communication/multichannelcommunication.cpp

@@ -113,14 +113,14 @@ void MultiChannelCommunication::readTask() {
 								continue;
 							}
 
-							// We want callbacks to be able to access errors
-							EventManager::GetInstance().cancelErrorDowngradingOnCurrentThread();
 							for(auto& cb : messageCallbacks) { // We might have closed while reading or processing
 								if(!closing) {
+									// We want callbacks to be able to access errors
+									EventManager::GetInstance().cancelErrorDowngradingOnCurrentThread();
 									cb.second.callIfMatch(msg);
+									EventManager::GetInstance().downgradeErrorsOnCurrentThread();
 								}
 							}
-							EventManager::GetInstance().downgradeErrorsOnCurrentThread();
 						}
 					}
 

device/device.cpp

@@ -203,14 +203,14 @@ bool Device::close() {
 		return false;
 	}
 
+	if(isOnline())
+		goOffline();
+	
 	if(internalHandlerCallbackID)
 		com->removeMessageCallback(internalHandlerCallbackID);
 
 	internalHandlerCallbackID = 0;
-
+	
-	if(isOnline())
-		goOffline();
-
 	return com->close();
 }
 

include/icsneo/api/eventmanager.h

@@ -58,7 +58,7 @@ public:
 				eventsLock.unlock();
 				runCallbacks(event);
 			} else {
-				std::lock_guard<std::mutex> lk(errorsMutex);
+				std::lock_guard<std::mutex> errorsLock(errorsMutex);
 				add_internal_error(event);
 			}
 		} else {

platform/posix/stm32.cpp

@@ -293,7 +293,6 @@ void STM32::readTask() {
 		if(bytesRead > 0)
 			readQueue.enqueue_bulk(readbuf, bytesRead);
 	}
-	EventManager::GetInstance().cancelErrorDowngradingOnCurrentThread();
 }
 
 void STM32::writeTask() {