From 21c3fead4a06efb98159f1f0b66762d46f456270 Mon Sep 17 00:00:00 2001
From: Paul Hollinsky <phollinsky@intrepidcs.com>
Date: Tue, 23 Jul 2019 15:04:50 -0400
Subject: [PATCH] Error checking for Encoder::encode UpdateLEDState

---
 communication/encoder.cpp | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/communication/encoder.cpp b/communication/encoder.cpp
index 5418f1b..06ed7de 100644
--- a/communication/encoder.cpp
+++ b/communication/encoder.cpp
@@ -106,14 +106,18 @@ bool Encoder::encode(std::vector<uint8_t>& result, Command cmd, std::vector<uint
 	if(cmd == Command::UpdateLEDState) {
 		/* NetID::Device is a super old command type.
 		 * It has a leading 0x00 byte, a byte for command, and a byte for an argument.
-	  	 * In this case, command 0x06 is SetLEDState.
+		 * In this case, command 0x06 is SetLEDState.
 		 * This old command type is not really used anywhere else.
 		 */
+		if (arguments.empty()) {
+			report(APIEvent::Type::MessageFormattingError, APIEvent::Severity::Error);
+			return false;
+		}
 		msg->network = Network::NetID::Device;
 		msg->data.reserve(3);
 		msg->data.push_back(0x00);
-		msg->data.push_back(0x06);
-		msg->data.push_back(arguments.at(0));
+		msg->data.push_back(0x06); // SetLEDState
+		msg->data.push_back(arguments.at(0)); // See Device::LEDState
 	} else {
 		msg->network = Network::NetID::Main51;
 		msg->data.reserve(arguments.size() + 1);