Resolve macOS warnings and standardize style

api/icsneocpp/include/icsneocpp.h

@@ -7,7 +7,9 @@
 #include "device/include/device.h"
 
 namespace icsneo {
-	std::vector<std::shared_ptr<Device>> FindAllDevices();
+
-};
+std::vector<std::shared_ptr<Device>> FindAllDevices();
+
+}
 
 #endif

communication/communication.cpp

@@ -13,7 +13,7 @@ int Communication::messageCallbackIDCounter = 1;
 
 uint8_t Communication::ICSChecksum(const std::vector<uint8_t>& data) {
 	uint32_t checksum = 0;
-	for(auto i = 0; i < data.size(); i++)
+	for(size_t i = 0; i < data.size(); i++)
 		checksum += data[i];
 	checksum = ~checksum;
 	checksum++;

communication/include/communication.h

@@ -60,6 +60,6 @@ private:
 	void readTask();
 };
 
-};
+}
 
 #endif

communication/include/icommunication.h

@@ -38,6 +38,6 @@ protected:
 	std::atomic<bool> closing{false};
 };
 
-};
+}
 
 #endif

communication/include/messagecallback.h

@@ -41,6 +41,6 @@ public:
 	CANMessageCallback(CANMessageFilter f, fn_messageCallback cb) : MessageCallback(cb, std::make_shared<CANMessageFilter>(f)) {}
 };
 
-};
+}
 
 #endif

communication/include/messagefilter.h

@@ -67,6 +67,6 @@ private:
 	}
 };
 
-};
+}
 
 #endif

communication/include/multichannelcommunication.h

@@ -97,6 +97,6 @@ private:
 	void readTask();
 };
 
-};
+}
 
 #endif

communication/include/network.h

@@ -335,6 +335,6 @@ private:
 	}
 };
 
-};
+}
 
 #endif

communication/message/include/canmessage.h

@@ -10,6 +10,6 @@ public:
 	uint32_t arbid;
 };
 
-};
+}
 
 #endif

communication/message/include/message.h

@@ -14,6 +14,6 @@ public:
 	uint64_t timestamp;
 };
 
-};
+}
 
 #endif

communication/message/include/neomessage.h

@@ -33,8 +33,10 @@ typedef struct {
 #include "communication/message/include/message.h"
 
 namespace icsneo {
-	neomessage_t CreateNeoMessage(const Message& message);
+
-};
+neomessage_t CreateNeoMessage(const Message& message);
+
+}
 #endif
 
 #endif

communication/multichannelcommunication.cpp

@@ -97,7 +97,7 @@ void MultiChannelCommunication::readTask() {
 						continue;
 					}
 
-					for(auto i = 0; i < currentReadIndex; i++)
+					for(size_t i = 0; i < currentReadIndex; i++)
 						usbReadFifo.pop_front();
 
 					payloadBytes.clear();

communication/packetizer.cpp

@@ -68,7 +68,7 @@ bool Packetizer::input(const std::vector<uint8_t>& inputBytes) {
 				break;
 			case ReadState::GetData:
 				// We do not include the checksum in packetLength so it doesn't get copied into the payload buffer
-				if(bytes.size() < packetLength + (checksum ? 1 : 0)) { // Read until we have the rest of the packet
+				if(bytes.size() < (size_t)(packetLength + (checksum ? 1 : 0))) { // Read until we have the rest of the packet
 					haveEnoughData = false;
 					break;
 				}

device/include/device.h

@@ -71,6 +71,6 @@ private:
 	void enforcePollingMessageLimit();
 };
 
-};
+}
 
 #endif

device/include/devicefinder.h

@@ -12,6 +12,6 @@ public:
 	static std::vector<std::shared_ptr<Device>> FindAll();
 };
 
-};
+}
 
 #endif

device/include/neodevice.h

@@ -6,8 +6,10 @@
 #ifdef __cplusplus
 // A forward declaration is needed as there is a circular dependency
 namespace icsneo {
-	class Device;
+
-};
+class Device;
+
+}
 typedef icsneo::Device* devicehandle_t;
 #else
 typedef void* devicehandle_t;

device/neoobd2pro/include/neoobd2pro.h

@@ -27,6 +27,6 @@ public:
 	}
 };
 
-};
+}
 
 #endif

device/neoobd2sim/include/neoobd2sim.h

@@ -27,6 +27,6 @@ public:
 	}
 };
 
-};
+}
 
 #endif

device/neovifire/include/neovifire.h

@@ -50,6 +50,6 @@ public:
 	}
 };
 
-};
+}
 
 #endif

device/neovifire2/include/neovifire2.h

@@ -14,6 +14,6 @@ public:
 	}
 };
 
-};
+}
 
 #endif

device/neovifire2/include/neovifire2eth.h

@@ -24,6 +24,6 @@ public:
 	}
 };
 
-};
+}
 
 #endif

device/neovifire2/include/neovifire2usb.h

@@ -24,6 +24,6 @@ public:
 	}
 };
 
-};
+}
 
 #endif

device/plasion/include/neoviion.h

@@ -25,6 +25,6 @@ public:
 	}
 };
 
-};
+}
 
 #endif

device/plasion/include/neoviplasma.h

@@ -25,6 +25,6 @@ public:
 	}
 };
 
-};
+}
 
 #endif

device/plasion/include/plasion.h

@@ -14,6 +14,6 @@ public:
 	}
 };
 
-};
+}
 
 #endif

device/radgalaxy/include/radgalaxy.h

@@ -27,6 +27,6 @@ public:
 	}
 };
 
-};
+}
 
 #endif

device/radstar2/include/radstar2.h

@@ -27,6 +27,6 @@ public:
 	}
 };
 
-};
+}
 
 #endif

device/radsupermoon/include/radsupermoon.h

@@ -29,6 +29,6 @@ public:
 	}
 };
 
-};
+}
 
 #endif

device/valuecan3/include/valuecan3.h

@@ -26,6 +26,6 @@ public:
 	}
 };
 
-};
+}
 
 #endif

device/valuecan4/include/valuecan4.h

@@ -27,6 +27,6 @@ public:
 	}
 };
 
-};
+}
 
 #endif

device/vividcan/include/vividcan.h

@@ -29,6 +29,6 @@ public:
 	}
 };
 
-};
+}
 
 #endif

platform/posix/include/ftdi.h

@@ -46,6 +46,6 @@ private:
 	FTDIDevice ftdiDevice;
 };
 
-};
+}
 
 #endif

platform/posix/include/stm32.h

@@ -26,6 +26,6 @@ private:
 	void writeTask();
 };
 
-};
+}
 
 #endif

platform/posix/stm32.cpp

@@ -273,8 +273,8 @@ void STM32::writeTask() {
 		if(!writeQueue.wait_dequeue_timed(writeOp, std::chrono::milliseconds(100)))
 			continue;
 
-		const auto writeSize = writeOp.bytes.size();
+		const ssize_t writeSize = (ssize_t)writeOp.bytes.size();
-		int actualWritten = ::write(fd, writeOp.bytes.data(), writeSize);
+		ssize_t actualWritten = ::write(fd, writeOp.bytes.data(), writeSize);
 		if(actualWritten != writeSize)
 			std::cout << "Failure to write " << writeSize << " bytes, wrote " << actualWritten << std::endl;
 	}

platform/windows/include/ftdi.h

@@ -11,6 +11,6 @@ public:
 	static std::vector<neodevice_t> FindByProduct(int product) { return VCP::FindByProduct(product, L"serenum"); }
 };
 
-};
+}
 
 #endif

platform/windows/include/pcap.h

@@ -65,6 +65,6 @@ private:
 	};
 };
 
-};
+}
 
 #endif

platform/windows/include/registry.h

@@ -28,6 +28,6 @@ private:
 	};
 };
 
-};
+}
 
 #endif

platform/windows/include/stm32.h

@@ -11,6 +11,6 @@ public:
 	static std::vector<neodevice_t> FindByProduct(int product) { return VCP::FindByProduct(product, L"usbser"); }
 };
 
-};
+}
 
 #endif

platform/windows/include/vcp.h

@@ -43,6 +43,6 @@ private:
 	void writeTask();
 };
 
-};
+}
 
 #endif

platform/windows/internal/include/pcapdll.h

@@ -48,6 +48,6 @@ private:
 	void closeDLL();
 };
 
-};
+}
 
 #endif