From 1e7dfa7a71915a43afdaa0a764a0fcc988a5a8af Mon Sep 17 00:00:00 2001 From: "Gowtham Nanjukutty (XC-CP/ECC2.3)" Date: Fri, 22 May 2026 09:13:41 -0400 Subject: [PATCH] servd: default Enabled() to false when LIBICSNEO_USE_SERVD is unset Previously, Servd::Enabled() returned true by default when the LIBICSNEO_USE_SERVD environment variable was not set. This caused DeviceFinder::FindAll() to take the Servd::Find() path and skip all direct transport discovery (CDCACM, DXX, PCAP, etc.) even when no servd daemon is running, silently returning zero devices. The intended behavior is opt-in: users who want to use servd should explicitly set LIBICSNEO_USE_SERVD=1. Change the default to false so direct device discovery works out of the box. LIBICSNEO_USE_SERVD=1 continues to enable servd as before. --- platform/servd.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/servd.cpp b/platform/servd.cpp index c3ffb614..78a89ca4 100644 --- a/platform/servd.cpp +++ b/platform/servd.cpp @@ -20,7 +20,7 @@ bool Servd::Enabled() { #ifdef _MSC_VER #pragma warning(pop) #endif - return enabled ? enabled[0] == '1' : true; + return enabled ? enabled[0] == '1' : false; } std::vector split(const std::string_view& str, char delim = ' ') {