sven
/
libicsneo
mirror of https://github.com/intrepidcs/libicsneo.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove unused parameters 

These can cause warnings (which we treat as errors) on MSVC
pull/35/head
Paul Hollinsky 2021-05-05 02:40:00 -04:00
parent e99107c1bc
commit 1bb114004e
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/icsneo/device/device.h
View File

@ -97,7 +97,7 @@ public:
using OpenStatusHandler = std::function<Device::OpenDirective(OpenStatusType type, const std::string& status, optional<double> progress)>; using OpenStatusHandler = std::function<Device::OpenDirective(OpenStatusType type, const std::string& status, optional<double> progress)>;
bool open(OpenFlags flags = {}, OpenStatusHandler handler = bool open(OpenFlags flags = {}, OpenStatusHandler handler =
[](OpenStatusType type, const std::string& _s, optional<double> _p) { return Device::OpenDirective::Continue; }); [](OpenStatusType, const std::string&, optional<double>) { return Device::OpenDirective::Continue; });
virtual bool close(); virtual bool close();
virtual bool isOnline() const { return online; } virtual bool isOnline() const { return online; }
virtual bool isOpen() const { return com->isOpen(); } virtual bool isOpen() const { return com->isOpen(); }
@ -328,7 +328,7 @@ protected:
void handleInternalMessage(std::shared_ptr<Message> message); void handleInternalMessage(std::shared_ptr<Message> message);
virtual void handleDeviceStatus(const std::shared_ptr<Message>& message) {} virtual void handleDeviceStatus(const std::shared_ptr<Message>&) {}
neodevice_t& getWritableNeoDevice() { return data; } neodevice_t& getWritableNeoDevice() { return data; }

4
include/icsneo/device/extensions/deviceextension.h
View File

@ -19,10 +19,10 @@ public:
virtual const char* getName() const = 0; virtual const char* getName() const = 0;
// Return false to block opening // Return false to block opening
virtual bool onDeviceOpen(Device::OpenFlags flags, const Device::OpenStatusHandler& handler) { return true; } virtual bool onDeviceOpen(Device::OpenFlags, const Device::OpenStatusHandler&) { return true; }
// Return true to indicate that communication should now be back // Return true to indicate that communication should now be back
virtual bool onDeviceCommunicationDead(Device::OpenFlags flags, const Device::OpenStatusHandler& handler) { return false; } virtual bool onDeviceCommunicationDead(Device::OpenFlags, const Device::OpenStatusHandler&) { return false; }
virtual void onGoOnline() {} virtual void onGoOnline() {}
virtual void onGoOffline() {} virtual void onGoOffline() {}