sven
/
libicsneo
mirror of https://github.com/intrepidcs/libicsneo.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

WiVICommandPacket: Remove length check

add-device-sharing
Emily Brooks 2022-07-06 16:26:53 -04:00
parent 9871430288
commit 124bd3b310
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
communication/packet/wivicommandpacket.cpp
View File

@ -15,9 +15,6 @@ std::shared_ptr<WiVI::ResponseMessage> WiVI::CommandPacket::DecodeToMessage(cons
if(bytestream.size() < sizeof(WiVI::CommandPacket::Result)) if(bytestream.size() < sizeof(WiVI::CommandPacket::Result))
return {}; return {};
if(bytestream.size() != sizeof(WiVI::CommandPacket::Header) + header.length)
return {};
const auto& decoded = *reinterpret_cast<const WiVI::CommandPacket::Result*>(bytestream.data()); const auto& decoded = *reinterpret_cast<const WiVI::CommandPacket::Result*>(bytestream.data());
msg->responseTo = decoded.responseTo; msg->responseTo = decoded.responseTo;
msg->success = decoded.result != 0; msg->success = decoded.result != 0;
@ -28,9 +25,6 @@ std::shared_ptr<WiVI::ResponseMessage> WiVI::CommandPacket::DecodeToMessage(cons
if(bytestream.size() < sizeof(WiVI::CommandPacket::SetSignal)) if(bytestream.size() < sizeof(WiVI::CommandPacket::SetSignal))
return {}; return {};
if(bytestream.size() != sizeof(WiVI::CommandPacket::SetSignal) + header.length)
return {};
const auto& setSignal = *reinterpret_cast<const WiVI::CommandPacket::SetSignal*>(bytestream.data()); const auto& setSignal = *reinterpret_cast<const WiVI::CommandPacket::SetSignal*>(bytestream.data());
msg->responseTo = WiVI::Command::GetSignal; msg->responseTo = WiVI::Command::GetSignal;
msg->value = setSignal.value.ValueInt32; msg->value = setSignal.value.ValueInt32;
@ -40,9 +34,6 @@ std::shared_ptr<WiVI::ResponseMessage> WiVI::CommandPacket::DecodeToMessage(cons
if(bytestream.size() < sizeof(WiVI::CommandPacket::GetAll)) if(bytestream.size() < sizeof(WiVI::CommandPacket::GetAll))
return {}; return {};
if(bytestream.size() != sizeof(WiVI::CommandPacket::GetAll) + header.length)
return {};
const auto& getAll = *reinterpret_cast<const WiVI::CommandPacket::GetAll*>(bytestream.data()); const auto& getAll = *reinterpret_cast<const WiVI::CommandPacket::GetAll*>(bytestream.data());
msg->responseTo = WiVI::Command::GetAll; msg->responseTo = WiVI::Command::GetAll;
msg->info.emplace(); msg->info.emplace();