sven
/
intrepid-socketcan-kernel-module
mirror of https://github.com/intrepidcs/intrepid-socketcan-kernel-module.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Update kernel logging for dropped messages to debug, leave memory and critical to warn and err

master
tstoddard 2025-08-05 09:42:54 -04:00
parent 1bdb4bbb50
commit 5123a30746
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
intrepid.c
View File

@ -219,7 +219,7 @@ static netdev_tx_t intrepid_CAN_netdevice_xmit(struct sk_buff *skb, struct net_d
neomessage_can_t msg = {0}; neomessage_can_t msg = {0};
if (can_dropped_invalid_skb(dev, skb)) { if (can_dropped_invalid_skb(dev, skb)) {
pr_info("intrepid: dropping invalid frame on %s\n", dev->name); pr_debug("intrepid: dropping invalid frame on %s\n", dev->name);
goto exit; goto exit;
} }
@ -798,7 +798,7 @@ static int intrepid_add_eth_if(struct intrepid_netdevice **result, const char *r
} }
else { else {
strncpy(dev->ifalias->ifalias, requestedName, aliasLen + 1); strncpy(dev->ifalias->ifalias, requestedName, aliasLen + 1);
pr_info("intrepid: %s alias sset to %s\n", dev->name, requestedName); pr_info("intrepid: %s alias set to %s\n", dev->name, requestedName);
} }
} }
#endif #endif
@ -866,7 +866,7 @@ static struct sk_buff *intrepid_skb_from_neomessage(
/* input validation */ /* input validation */
if (unlikely(device == NULL || msg_generic == NULL || data == NULL || stats == NULL)) { if (unlikely(device == NULL || msg_generic == NULL || data == NULL || stats == NULL)) {
stats->rx_dropped++; stats->rx_dropped++;
pr_warn("intrepid: Dropping message on %s, skb from neomessage input validation failed", device->name); pr_debug("intrepid: Dropping message on %s, skb from neomessage input validation failed", device->name);
goto out; goto out;
} }
switch (msg_generic->type) { switch (msg_generic->type) {
@ -928,12 +928,12 @@ static struct sk_buff *intrepid_skb_from_neomessage(
} }
break; break;
default: default:
pr_warn("intrepid: Dropping message on %s, invalid type %d", device->name, msg_generic->type); pr_debug("intrepid: Dropping message on %s, invalid type %d", device->name, msg_generic->type);
goto out; goto out;
} }
if (unlikely(ret != 0)) { if (unlikely(ret != 0)) {
pr_warn("intrepid: Dropping message on %s, frame fill failed", device->name); pr_debug("intrepid: Dropping message on %s, frame fill failed", device->name);
goto out; goto out;
} }
out: out:
@ -977,7 +977,7 @@ static int intrepid_read_messages(int device_index, unsigned int count)
ret = netif_rx(skb); ret = netif_rx(skb);
if (ret == NET_RX_DROP) if (ret == NET_RX_DROP)
pr_warn("intrepid: Dropping message on %s, dropped by kernel", device->name); pr_debug("intrepid: Dropping message on %s, dropped by kernel", device->name);
} }
spin_unlock_bh(&ics->lock); spin_unlock_bh(&ics->lock);