Compare commits

..

4 Commits

Author SHA1 Message Date
Oleksij Rempel 3b7f0bc6b9
Merge e5fd45a198 into 14245b7c79 2026-05-12 06:50:44 +00:00
Oleksij Rempel e5fd45a198 canlogserver: fix infinite loops during signal handling
Fix infinite loops that prevent graceful termination when the server
receives SIGINT or SIGTERM signals. Without this fix, Ctrl-C and kill
commands are ignored, making it impossible to stop the server cleanly.

Two scenarios cause the infinite loops:

1) The bind() retry loop: When the port is busy, the loop retries
   indefinitely without checking the running flag set by the signal
   handler.

2) The accept() loop: The loop is unconditional, so when accept() is
   interrupted by a signal and returns EINTR, the loop immediately
   restarts, ignoring the shutdown request.

Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
2026-05-12 07:11:34 +02:00
Marc Kleine-Budde 14245b7c79
Merge pull request #627 from SamantazFox/patch-2
J1939: Handle localtime_r() failure in TD PG
2026-05-11 10:16:48 +02:00
Samantaz Fox d5cb91c8ea
Handle localtime_r() failure in j1939 timedate
When the call to localtime_r() fails (by returning NULL, as per the POSIX specification), make sure to fill the hour/minute offsets with the fallback values as specified in the J1939DA supporting information.
2026-05-08 17:00:31 +02:00
2 changed files with 24 additions and 10 deletions

View File

@ -296,6 +296,10 @@ int main(int argc, char **argv)
nanosleep(&f, NULL); nanosleep(&f, NULL);
} }
/*
* Check if loop exited due to signal (during nanosleep) rather than
* successful bind.
*/
if (!running) { if (!running) {
close(socki); close(socki);
return 128 + signal_num; return 128 + signal_num;
@ -321,6 +325,10 @@ int main(int argc, char **argv)
} }
} }
/*
* Check if loop exited due to signal (accept returned EINTR) rather
* than successful fork
*/
if (!running) { if (!running) {
if (accsocket > 0) if (accsocket > 0)
close(accsocket); close(accsocket);

View File

@ -41,16 +41,22 @@ static void gmtime_to_j1939_pgn_65254_td(struct j1939_time_date_packet *tdp)
utc_tm = gmtime_r(&now, &utc_tm_buf); utc_tm = gmtime_r(&now, &utc_tm_buf);
local_tm = localtime_r(&now, &local_tm_buf); local_tm = localtime_r(&now, &local_tm_buf);
/* Calculate the offsets */ if (local_tm) {
hour_offset = local_tm->tm_hour - utc_tm->tm_hour; /* Calculate the offsets */
minute_offset = local_tm->tm_min - utc_tm->tm_min; hour_offset = local_tm->tm_hour - utc_tm->tm_hour;
minute_offset = local_tm->tm_min - utc_tm->tm_min;
/* Handle date rollover */ /* Handle date rollover */
if (local_tm->tm_mday != utc_tm->tm_mday) { if (local_tm->tm_mday != utc_tm->tm_mday) {
if (local_tm->tm_hour < 12) if (local_tm->tm_hour < 12)
hour_offset += 24; /* past midnight */ hour_offset += 24; /* past midnight */
else else
hour_offset -= 24; /* before midnight */ hour_offset -= 24; /* before midnight */
}
} else {
/* The local time offsets cannot be determined at the moment */
hour_offset = 0xF9;
minute_offset = 0xFF;
} }
/* /*