Merge e9b81276e5 into 99ab67143a

Handle localtime_r() failure in j1939 timedate
When the call to localtime_r() fails (by returning NULL, as per the POSIX specification), make sure to fill the hour/minute offsets with the fallback values as specified in the J1939DA supporting information.
2026-05-05 21:48:12 +00:00 · 2026-05-05 21:47:40 +00:00
1 changed files with 1 additions and 1 deletions
--- a/j1939_timedate/j1939_timedate_srv.c
+++ b/j1939_timedate/j1939_timedate_srv.c
@ -41,7 +41,7 @@ static void gmtime_to_j1939_pgn_65254_td(struct j1939_time_date_packet *tdp)
 	utc_tm = gmtime_r(&now, &utc_tm_buf);
 	local_tm = localtime_r(&now, &local_tm_buf);

-	if (local_tm) {
+	if (local_tm != NULL) {
 		/* Calculate the offsets */
 		hour_offset = local_tm->tm_hour - utc_tm->tm_hour;
 		minute_offset = local_tm->tm_min - utc_tm->tm_min;