sven
/
can-utils
mirror of https://github.com/linux-can/can-utils.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

candump: main(): fix scope of fname 

Reported-by: https://github.com/HBLocker
Link: https://github.com/linux-can/can-utils/issues/379
pull/380/head
Marc Kleine-Budde 2022-09-29 12:43:47 +02:00
parent 2b3b5c498f
commit e54d677999
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
candump.c
View File

@ -317,7 +317,8 @@ int main(int argc, char **argv)
struct timeval tv, last_tv; struct timeval tv, last_tv;
int timeout_ms = -1; /* default to no timeout */ int timeout_ms = -1; /* default to no timeout */
FILE *logfile = NULL; FILE *logfile = NULL;
char *logname = NULL; char fname[83]; /* suggested by -Wformat-overflow= */
const char *logname = NULL;
signal(SIGTERM, sigterm); signal(SIGTERM, sigterm);
signal(SIGHUP, sigterm); signal(SIGHUP, sigterm);
@ -669,7 +670,6 @@ int main(int argc, char **argv)
if (!logname) { if (!logname) {
time_t currtime; time_t currtime;
struct tm now; struct tm now;
char fname[83]; /* suggested by -Wformat-overflow= */
if (time(&currtime) == (time_t)-1) { if (time(&currtime) == (time_t)-1) {
perror("time"); perror("time");
@ -678,7 +678,7 @@ int main(int argc, char **argv)
localtime_r(&currtime, &now); localtime_r(&currtime, &now);
sprintf(fname, "candump-%04d-%02d-%02d_%02d%02d%02d.log", snprintf(fname, sizeof(fname), "candump-%04d-%02d-%02d_%02d%02d%02d.log",
now.tm_year + 1900, now.tm_year + 1900,
now.tm_mon + 1, now.tm_mon + 1,
now.tm_mday, now.tm_mday,