mirror of
https://github.com/linux-can/can-utils.git
synced 2026-11-04 15:31:10 +01:00
isobusfs: treat interactive exit as control flow, not error
The cmd_exit() function used -EINTR to signal a clean exit from the interactive mode. This is semantically incorrect because EINTR is an errno value meant for system call interruptions, not application-level control flow. Stop using -EINTR for cmd_exit(). Introduce ISOBUSFS_CLI_RET_EXIT (a positive return code) to distinguish control flow from actual errors. Map this to exit code 0 in main(), keeping negative errno values for real errors. This makes the exit path explicit and prevents confusion with actual interrupted system calls. Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
This commit is contained in:
@@ -13,6 +13,9 @@
|
||||
#define ISOBUSFS_CLI_MAX_EPOLL_EVENTS 10
|
||||
#define ISOBUSFS_CLI_DEFAULT_WAIT_TIMEOUT_MS 1000 /* ms */
|
||||
|
||||
/* internal return codes, not errno values */
|
||||
#define ISOBUSFS_CLI_RET_EXIT 1
|
||||
|
||||
enum isobusfs_cli_state {
|
||||
ISOBUSFS_CLI_STATE_CONNECTING,
|
||||
ISOBUSFS_CLI_STATE_IDLE,
|
||||
|
||||
Reference in New Issue
Block a user