Add j1939 VP2 details

Add 3 missing unused bytes (for a message len of 8) to the j1939 VP2 struct, as well as range information for the existing parameters.
pull/626/head
Samantaz Fox 2026-05-05 20:56:39 +00:00 committed by GitHub
parent d5ed23583c
commit 9743a2ffcf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 6 deletions

View File

@ -142,42 +142,48 @@ j1939_vp1_set_longitude(struct j1939_vp1_packet *packet, int32_t longitude)
/** /**
* struct j1939_vp2_packet - Represents the PGN 64502 Vehicle * struct j1939_vp2_packet - Represents the PGN 64502 Vehicle
* Position 2 packet * Position 2 packet
* FIXME: current packet layout is guessed based on limited information:
* https://www.isobus.net/isobus/pGNAndSPN/10801?type=PGN
* *
* @total_satellites: Total number of satellites in view * @total_satellites: Total number of satellites in view
* - SPN: 8128 * - SPN: 8128
* - Data Length: 1 byte * - Data Length: 1 byte
* - Range: 0 to 250
* *
* @hdop: Horizontal dilution of precision * @hdop: Horizontal dilution of precision
* - SPN: 8129 * - SPN: 8129
* - Data Length: 1 byte * - Data Length: 1 byte
* - Resolution: 0.1 * - Resolution: 0.1
* - Range: 0.0 to 25.0
* *
* @vdop: Vertical dilution of precision * @vdop: Vertical dilution of precision
* - SPN: 8130 * - SPN: 8130
* - Data Length: 1 byte * - Data Length: 1 byte
* - Resolution: 0.1 * - Resolution: 0.1
* - Range: 0.0 to 25.0
* *
* @pdop: Position dilution of precision * @pdop: Position dilution of precision
* - SPN: 8131 * - SPN: 8131
* - Data Length: 1 byte * - Data Length: 1 byte
* - Resolution: 0.1 * - Resolution: 0.1
* - Range: 0.0 to 25.0
* *
* @tdop: Time dilution of precision * @tdop: Time dilution of precision
* - SPN: 8132 * - SPN: 8132
* - Data Length: 1 byte * - Data Length: 1 byte
* - Resolution: 0.1 * - Resolution: 0.1
* - Range: 0.0 to 25.0
* *
* This structure defines each component of the Vehicle Position 2 as described * This structure defines each component of the Vehicle Position 2 as described
* in PGN 64502. * in PGN 64502.
*/ */
struct j1939_vp2_packet { struct j1939_vp2_packet {
uint8_t total_satellites; /* SPN 8128 */ uint8_t total_satellites; /* SPN 8128 */
uint8_t hdop; /* SPN 8129 */ uint8_t hdop; /* SPN 8129 */
uint8_t vdop; /* SPN 8130 */ uint8_t vdop; /* SPN 8130 */
uint8_t pdop; /* SPN 8131 */ uint8_t pdop; /* SPN 8131 */
uint8_t tdop; /* SPN 8132 */ uint8_t tdop; /* SPN 8132 */
uint8_t unused5; /* Always 0xFF */
uint8_t unused6; /* Always 0xFF */
uint8_t unused7; /* Always 0xFF */
} __attribute__((__packed__)); } __attribute__((__packed__));
/** /**