From 0b84a782c26c064815ec9102f8a4d38aaefc5a52 Mon Sep 17 00:00:00 2001 From: Marc Kleine-Budde Date: Wed, 7 Dec 2022 16:29:39 +0100 Subject: [PATCH 1/2] mcp251xfd-dump: fix comparison of integer expressions of different signedness warning Signed-off-by: Marc Kleine-Budde --- mcp251xfd/mcp251xfd-dump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mcp251xfd/mcp251xfd-dump.c b/mcp251xfd/mcp251xfd-dump.c index e84e580..eb2e1ed 100644 --- a/mcp251xfd/mcp251xfd-dump.c +++ b/mcp251xfd/mcp251xfd-dump.c @@ -232,7 +232,7 @@ static void mcp251xfd_dump_reg_intf(const struct mcp251xfd_priv *priv, u32 val, #define __create_dump_fifo_bitmask(fifo, name, description) \ static void mcp251xfd_dump_reg_##fifo(const struct mcp251xfd_priv *priv, u32 val, u16 addr) \ { \ - int i; \ + size_t i; \ \ pr_info(__stringify(name) ": " __stringify(fifo) "(0x%03x)=0x%08x\n", addr, val); \ pr_info(description ":\n"); \ @@ -244,7 +244,7 @@ static void mcp251xfd_dump_reg_##fifo(const struct mcp251xfd_priv *priv, u32 val pr_info("\t\t"); \ for (i = 0; i < sizeof(val); i++) { \ if (val & BIT(i)) \ - pr_cont("%d ", i); \ + pr_cont("%zd ", i); \ } \ \ pr_cont("\n"); \ From 7e8cfac0de6d83bf413a89cd3b4505fa3ce8abb4 Mon Sep 17 00:00:00 2001 From: Marc Kleine-Budde Date: Wed, 7 Dec 2022 16:34:37 +0100 Subject: [PATCH 2/2] j1939cat: j1939cat_send(): fix uninitialized variable --- j1939cat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/j1939cat.c b/j1939cat.c index 34a8c03..4234aad 100644 --- a/j1939cat.c +++ b/j1939cat.c @@ -509,7 +509,7 @@ static int j1939cat_send(struct j1939cat_priv *priv) { unsigned int size = 0; unsigned int i; - int ret; + int ret = 0; if (priv->todo_filesize) size = j1939cat_get_file_size(priv->infile);