From 90383a0cca329869fe5d1d06fdb67ffc525bd32e Mon Sep 17 00:00:00 2001 From: Samantaz Fox Date: Fri, 8 May 2026 17:18:03 +0200 Subject: [PATCH] Fill unassigned bytes with 0xFF in J1939 VP2 --- j1939_vehicle_position/j1939_vehicle_position_srv.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/j1939_vehicle_position/j1939_vehicle_position_srv.c b/j1939_vehicle_position/j1939_vehicle_position_srv.c index 1ed9c74..3cfd923 100644 --- a/j1939_vehicle_position/j1939_vehicle_position_srv.c +++ b/j1939_vehicle_position/j1939_vehicle_position_srv.c @@ -270,6 +270,12 @@ static int j1939_vp2_get_data(struct j1939_vp_srv_priv *priv, j1939_vp2_set_pdop(vp2p, pdop); j1939_vp2_set_tdop(vp2p, tdop); + /* This PG's last 3 bytes are not assigned and hence must be set + * to 0xFF as per J1939-71, section 5.2 */ + vp2p->unused5 = 0xFF; + vp2p->unused6 = 0xFF; + vp2p->unused7 = 0xFF; + return 0; }