sven
/
can-utils
mirror of https://github.com/linux-can/can-utils.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: fix comparison types by casting 

A cast was introduced to fix comparison types. Now, both sides of the inequality contain signed types and issue #369 should be solved.
pull/371/head
Francisco J. Solis 2022-07-02 19:05:06 -05:00
parent cfe13a4c7d
commit 5e25642ba7
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib.c
View File

@ -572,13 +572,13 @@ static int snprintf_error_data(char *buf, size_t len, uint8_t err,
if (count){ if (count){
/* Fix for potential buffer overflow https://lgtm.com/rules/1505913226124/ */ /* Fix for potential buffer overflow https://lgtm.com/rules/1505913226124/ */
tmp_n = snprintf(buf + n, len - n, ","); tmp_n = snprintf(buf + n, len - n, ",");
if (tmp_n < 0 || tmp_n >= len - n){ if (tmp_n < 0 || tmp_n >= (int)len - n){
return n; return n;
} }
n += tmp_n; n += tmp_n;
} }
tmp_n = snprintf(buf + n, len - n, "%s", arr[i]); tmp_n = snprintf(buf + n, len - n, "%s", arr[i]);
if (tmp_n < 0 || tmp_n >= len - n){ if (tmp_n < 0 || tmp_n >= (int)len - n){
return n; return n;
} }
n += tmp_n; n += tmp_n;
@ -658,13 +658,13 @@ void snprintf_can_error_frame(char *buf, size_t len, const struct canfd_frame *c
if (classes){ if (classes){
/* Fix for potential buffer overflow https://lgtm.com/rules/1505913226124/ */ /* Fix for potential buffer overflow https://lgtm.com/rules/1505913226124/ */
tmp_n = snprintf(buf + n, len - n, "%s", sep); tmp_n = snprintf(buf + n, len - n, "%s", sep);
if (tmp_n < 0 || tmp_n >= len - n){ if (tmp_n < 0 || tmp_n >= (int)len - n){
return; return;
} }
n += tmp_n; n += tmp_n;
} }
tmp_n = snprintf(buf + n, len - n, "%s", error_classes[i]); tmp_n = snprintf(buf + n, len - n, "%s", error_classes[i]);
if (tmp_n < 0 || tmp_n >= len - n){ if (tmp_n < 0 || tmp_n >= (int)len - n){
return; return;
} }
n += tmp_n; n += tmp_n;