sven
/
can-utils
mirror of https://github.com/linux-can/can-utils.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

j1939spy: remove verbose option 

If j1939spy is started with the verbose option "-v" or "--verbose", it
will print the error "j1939spy: listening: Success" and exit. Remove
this option altogether.

Fixes: c50b5a39de ("can-j1939: add jspy 'sniffer' program")
pull/468/head
Marc Kleine-Budde 2023-10-17 09:50:49 +02:00
parent 51ee436e75
commit 574df84a5d
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
j1939spy.c
View File

@ -33,7 +33,6 @@ static const char help_msg[] =
"j1939spy: An SAE J1939 spy utility" "\n" "j1939spy: An SAE J1939 spy utility" "\n"
"Usage: j1939spy [OPTION...] [[IFACE:][NAME|SA][,PGN]]" "\n" "Usage: j1939spy [OPTION...] [[IFACE:][NAME|SA][,PGN]]" "\n"
"Options:\n" "Options:\n"
" -v, --verbose Increase verbosity" "\n"
" -P, --promisc Run in promiscuous mode" "\n" " -P, --promisc Run in promiscuous mode" "\n"
" (= receive traffic not for this ECU)" "\n" " (= receive traffic not for this ECU)" "\n"
" -b, --block=SIZE Use a receive buffer of SIZE (default 1024)" "\n" " -b, --block=SIZE Use a receive buffer of SIZE (default 1024)" "\n"
@ -43,8 +42,6 @@ static const char help_msg[] =
#ifdef _GNU_SOURCE #ifdef _GNU_SOURCE
static struct option long_opts[] = { static struct option long_opts[] = {
{ "help", no_argument, NULL, '?', }, { "help", no_argument, NULL, '?', },
{ "verbose", no_argument, NULL, 'v', },
{ "promisc", no_argument, NULL, 'P', }, { "promisc", no_argument, NULL, 'P', },
{ "block", required_argument, NULL, 'b', }, { "block", required_argument, NULL, 'b', },
{ "time", optional_argument, NULL, 't', }, { "time", optional_argument, NULL, 't', },
@ -60,7 +57,6 @@ static const char optstring[] = "vPb:t::?";
* static variables * static variables
*/ */
static struct { static struct {
int verbose;
struct sockaddr_can addr; struct sockaddr_can addr;
int promisc; int promisc;
int time; int time;
@ -108,9 +104,6 @@ int main(int argc, char **argv)
/* argument parsing */ /* argument parsing */
while ((opt = getopt_long(argc, argv, optstring, long_opts, NULL)) != -1) while ((opt = getopt_long(argc, argv, optstring, long_opts, NULL)) != -1)
switch (opt) { switch (opt) {
case 'v':
++s.verbose;
break;
case 'b': case 'b':
s.pkt_len = strtoul(optarg, 0, 0); s.pkt_len = strtoul(optarg, 0, 0);
break; break;
@ -207,8 +200,6 @@ int main(int argc, char **argv)
msg.msg_control = &ctrlmsg; msg.msg_control = &ctrlmsg;
memset(&tref, 0, sizeof(tref)); memset(&tref, 0, sizeof(tref));
if (s.verbose)
err(0, "listening");
while (1) { while (1) {
/* these settings may be modified by recvmsg() */ /* these settings may be modified by recvmsg() */
iov.iov_len = s.pkt_len; iov.iov_len = s.pkt_len;