candump: reduce printf calls for logfile format

The creation of the logfile format was using fprint_canframe() and two other
fprintf() calls to produce a single logfile format line. Instead of using
fprint_canframe() use sprint_canframe() directly and reduce the printf() calls
from three to one.

Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>

candump.c

@@ -698,18 +698,23 @@ int main(int argc, char **argv)
 					view |= CANLIB_VIEW_INDENT_SFF;
 
 				if (log) {
+					char buf[CL_CFSZ]; /* max length */
+
 					/* log CAN frame with absolute timestamp & device */
-					fprintf(logfile, "(%010ld.%06ld) ", tv.tv_sec, tv.tv_usec);
+					sprint_canframe(buf, &frame, 0, maxdlen);
-					fprintf(logfile, "%*s ", max_devname_len, devname[idx]);
+					fprintf(logfile, "(%010ld.%06ld) %*s %s\n",
-					/* without separator as logfile use-case is parsing */
+						tv.tv_sec, tv.tv_usec,
-					fprint_canframe(logfile, &frame, "\n", 0, maxdlen);
+						max_devname_len, devname[idx], buf);
 				}
 
 				if (logfrmt) {
+					char buf[CL_CFSZ]; /* max length */
+
 					/* print CAN frame in log file style to stdout */
-					printf("(%010ld.%06ld) ", tv.tv_sec, tv.tv_usec);
+					sprint_canframe(buf, &frame, 0, maxdlen);
-					printf("%*s ", max_devname_len, devname[idx]);
+					printf("(%010ld.%06ld) %*s %s\n",
-					fprint_canframe(stdout, &frame, "\n", 0, maxdlen);
+					       tv.tv_sec, tv.tv_usec,
+					       max_devname_len, devname[idx], buf);
 					goto out_fflush; /* no other output to stdout */
 				}