sven/can-utils
1
0
Fork 0
mirror of https://github.com/linux-can/can-utils.git synced 2026-08-05 06:20:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

cangen: use if_nametoindex() to avoid overflows

Browse Source 
This patch replaces strcpy() + ioctl() by if_nametoindex() to avoid
overflows caused by long user input.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
This commit is contained in:
Marc Kleine-Budde
2022-12-07 15:28:18 +01:00
parent 0f7c1aa23a
commit 1f96d674c0
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cangen.c
+3 -5
View File
@@ -321,13 +321,11 @@ int main(int argc, char **argv)
} }
addr.can_family = AF_CAN; addr.can_family = AF_CAN;
addr.can_ifindex = if_nametoindex(argv[optind]);
strcpy(ifr.ifr_name, argv[optind]); if (!addr.can_ifindex) {
if (ioctl(s, SIOCGIFINDEX, &ifr) < 0) { perror("if_nametoindex");
perror("SIOCGIFINDEX");
return 1; return 1;
} }
addr.can_ifindex = ifr.ifr_ifindex;
/* /*
* disable default receive filter on this RAW socket * disable default receive filter on this RAW socket